Enforce retry defaults to ensure sufficient retries regardless of PySQL #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
jackyhu-db
previously approved these changes
Jan 17, 2025
jackyhu-db
reviewed
Jan 17, 2025
eric-wang-1990
previously approved these changes
Jan 17, 2025
benc-db
dismissed stale reviews from eric-wang-1990 and jackyhu-db
via
ca8f868
eric-wang-1990
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although 3.7.1 of PySQL should address the 503 issues, this is another way to ensure that retry defaults are sufficiently long. Users can still overwrite, but this provides dbt appropriate defaults for the key retry parameters.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.